Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create com.github.sammarxz.pomerode.json #541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create com.github.sammarxz.pomerode.json #541

wants to merge 1 commit into from

Conversation

sammarxz
Copy link

@sammarxz sammarxz commented Nov 25, 2024 •
edited by elementaryBot
Loading

pomerode-preview

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • Custom colors meet WCAG A contrast or greater
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@sammarxz sammarxz requested a review from a team as a code owner November 25, 2024 13:33
danirabbit
danirabbit requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for your submission. It looks like your app was build against the GNOME Runtime. Apps in AppCenter must be build against the elementary runtime. See publishing requirements for this and other requirements: https://docs.elementary.io/develop/appcenter/publishing-requirements

@ryonakano ryonakano mentioned this pull request Dec 17, 2024
Merged
3 tasks
@ryonakano
Copy link
Member

@sammarxz The above issue has been resolved by sammarxz/pomerode#1, but you need to create a new release to include these changes and update the commit and version in applications/com.github.sammarxz.pomerode.json in this branch.

Also, your app uses Adwaita stylesheet which is not accepted (see #429 (review)). However, you don't need to subclass Gtk.Application these days and just calling Granite.init () in the startup () method of your application class (like this) should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sammarxz @ryonakano @danirabbit